De-circularize Colorbar and Colorscale modules #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename Plotly.Colorbar -> Colorbar.draw
| var attributes = require('./attributes'); | ||
|
|
||
|
|
||
| module.exports = function draw(gd, id) { |
There was a problem hiding this comment.
Plotly.Colorbar used to be a function with .attributes and .supplyDefaults attached to it which was rather confusing.
Now, the main Colorbar method is call draw.
|
Looks good to me. Thanks for highlighting & commenting on real changes @etpinard ! 💃 |
|
Oh man, these will make huge improvements for read/maintainability. 👍 💃 |
etpinard
added a commit
that referenced
this pull request
Dec 21, 2015
De-circularize Colorbar and Colorscale modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cldougl @mdtusz @alexcjohnson
Before this PR
ColorbarandColorscalehad a circular dependencies.By breaking both modules into smaller 1-file-per-method pieces, both modules can be required without any issues.
Most of this PR only moved content around. Real changes are highlighted below.