Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clear parcoords canvas specially if no panels exist #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2017

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Mar 3, 2017

Reason: if there's no panel, then the panel redaw loop will not enter the loop body that also clears the canvas, causing uncleared lines when only 0 or 1 dimension exists (as visible dimensions) after rendering, then making other dimensions go invisible with Plotly.restyle.

…aw loop will not enter the loop body that also clears
@monfera monfera added status: reviewable bug something broken labels Mar 3, 2017
@etpinard
Copy link
Contributor

etpinard commented Mar 3, 2017

Great! Can you add a test case to 🔒 this down?

@etpinard
Copy link
Contributor

etpinard commented Mar 6, 2017

This fix would be nice addition to the next patch release 1.24.1. @monfera have you had the time to think about a way to add a test case?

@monfera
Copy link
Contributor Author

monfera commented Mar 6, 2017

@etienne my conclusion from our chat is that we'll need to persist the regl object on the element; it'll make it possible to have access to it for testing. I can go ahead with it today.

@monfera
Copy link
Contributor Author

monfera commented Mar 6, 2017

@etpinard specifically, we already bind (with D3) the lineLayer object that has a readPixel method for picking - I'll just make a similar method for reading all pixels in a rectangle, so no need for the entire regl object.

@etpinard
Copy link
Contributor

etpinard commented Mar 6, 2017

specifically, we already bind (with D3) the lineLayer object that has a readPixel method for picking - I'll just make a similar method for reading all pixels in a rectangle, so no need for the entire regl object.

Sounds good. Thanks!

Copy link
Contributor

@etpinard etpinard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @monfera

Merge away 🚀

@monfera monfera merged commit ed5e520 into master Mar 6, 2017
@monfera monfera deleted the clear-parcoords-canvas-of-zero-panels branch March 6, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants