Thanks to visit codestin.com
Credit goes to github.com

Skip to content

supplyTransformDefaults to fill in missing transformModules #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rreusser merged 2 commits into from
Apr 7, 2017
Merged

supplyTransformDefaults to fill in missing transformModules #1568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b858a6
supplyTransformDefaults to fill in missing transformModules
rreusser Apr 7, 2017
bc99323
Add test for supplyTransformDefaults
rreusser Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test for supplyTransformDefaults
  • Loading branch information
@rreusser
rreusser committed Apr 7, 2017
commit bc99323eb86cd2104c3d03daddd73ca2432e99f4
6 changes: 3 additions & 3 deletions src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,13 +824,13 @@ plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInInde
coerce('legendgroup');
}

supplyTransformDefaults(traceIn, traceOut, layout);
plots.supplyTransformDefaults(traceIn, traceOut, layout);
}

return traceOut;
};

function supplyTransformDefaults(traceIn, traceOut, layout) {
plots.supplyTransformDefaults = function(traceIn, traceOut, layout) {
var globalTransforms = layout._globalTransforms || [];
var transformModules = layout._transformModules || [];

Expand Down Expand Up @@ -861,7 +861,7 @@ function supplyTransformDefaults(traceIn, traceOut, layout) {

containerOut.push(transformOut);
}
}
};

function applyTransforms(fullTrace, fullData, layout, fullLayout) {
var container = fullTrace.transforms,
Expand Down
14 changes: 14 additions & 0 deletions test/jasmine/tests/plots_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,20 @@ describe('Test Plots', function() {
});
});

describe('Plots.supplyTransformDefaults', function() {
it('should accept an empty layout when transforms present', function() {
var traceOut = {};
Plots.supplyTransformDefaults({}, traceOut, {
_globalTransforms: [{ type: 'filter'}]
});

// This isn't particularly interseting. More relevant is that
// the above supplyTransformDefaults call didn't fail due to
// missing transformModules data.
expect(traceOut.transforms.length).toEqual(1);
});
});

describe('Plots.getSubplotIds', function() {
var getSubplotIds = Plots.getSubplotIds;

Expand Down