Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix automargin when ticklabelmode is set to period #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fix automargin when ticklabelmode is set to period #5134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd2e89
fix issue 5132
archmoj Sep 8, 2020
969c9c8
add image test to lock 5132
archmoj Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ axes.calcTicks = function calcTicks(ax, opts) {
ticksOut[i].periodX = v;

if(v > maxRange || v < minRange) { // hide label if outside the range
ticksOut[i].text = '';
ticksOut[i].text = ' '; // don't use an empty string here which can confuse automargin (issue 5132)
removedPreTick0Label = true;
}
}
Expand Down
Binary file added test/image/baselines/date_axes_period_breaks_automargin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading