tick text description typo #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,7 +180,7 @@ module.exports = { | |||
| description: [ | |||
| 'Sets the text displayed at the ticks position via `tickvals`.', | |||
| 'Only has an effect if `tickmode` is set to *array*.', | |||
There was a problem hiding this comment.
It depends what we mean by set.
Does set mean:
- that
tickmodehas to be set by the user to'array', or - that
tickmodeis either set by the user to'array'or inferred to be'array'bytickvals.
I think item 1. is probably what most people would understand by set. But how should we describe situation similar to item 2. ?
There was a problem hiding this comment.
ahh yes you're totally right, I wasn't thinking about opt 2.
We should probably leave as is for now then. (but just change the typo in this commit)
|
Great. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.