Replace calls to deprecated String.substr() #6146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timeowilliams
approved these changes
Mar 19, 2022
|
The 'substring' method appears to have some strange behavior. See https://masteringjs.io/tutorials/fundamentals/substring Perhaps safer to use the slice method instead? |
.substring()|
Kind of agree with people questioning that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #6078.
This is quite tricky whereas several
npmpackages are also affected.For now we tried to achieve that by finding & replacing any
.substr(a, ?b)with.slice(a, (a)+ b)in all types of bundles.@plotly/plotly_js
cc: @timeowilliams