Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revise extra bundles creation #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Revise extra bundles creation #6150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9051a04
call extra-bundles once - now prependFile step is sync
archmoj Mar 18, 2022
657c08b
adjust strict bundle headers
archmoj Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"use-draftlogs": "node tasks/use_draftlogs.js",
"empty-draftlogs": "node tasks/empty_draftlogs.js",
"empty-dist": "node tasks/empty_dist.js",
"build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles basic && npm run extra-bundles cartesian && npm run extra-bundles geo && npm run extra-bundles gl2d && npm run extra-bundles gl3d && npm run extra-bundles mapbox && npm run extra-bundles finance && npm run locales && npm run schema dist && npm run stats",
"build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles && npm run locales && npm run schema dist && npm run stats",
"regl-codegen": "node devtools/regl_codegen/server.js",
"cibuild": "npm run empty-dist && npm run preprocess && node tasks/cibundle.js",
"watch": "node tasks/watch.js",
Expand Down
4 changes: 2 additions & 2 deletions tasks/bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ tasks.push(function(done) {
standalone: 'Plotly',
pathToMinBundle: pathToPlotlyStrictDistMin
}, function() {
prependFile.sync(pathToPlotlyStrictDist, header, common.throwOnError);
prependFile.sync(pathToPlotlyStrictDistMin, header, common.throwOnError);
prependFile.sync(pathToPlotlyStrictDist, header.replace('plotly.js', 'plotly.js (strict)'), common.throwOnError);
prependFile.sync(pathToPlotlyStrictDistMin, header.replace('plotly.js', 'plotly.js (strict - minified)'), common.throwOnError);

done();
});
Expand Down
3 changes: 3 additions & 0 deletions tasks/extra_bundles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ var tasks = [];
for(var i = 0; i < list.length; i++) {
var opts = list[i];

// strict bundle is no longer a partial bundle and generated with bundles
if(opts.name === 'strict') continue;

partialBundle(tasks, {
name: opts.name,
index: opts.index,
Expand Down