Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix hovering over Sankey node only fully highlights first trace #6799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Fix hovering over Sankey node only fully highlights first trace #6799

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81998ac
Fix 6328 - Hovering over Sankey node highlights all full traces
CelineWuest Nov 27, 2023
b3efac2
Add draft log for PR 6799
CelineWuest Nov 27, 2023
2689419
Fix linter errors
CelineWuest Nov 27, 2023
0527052
Improve if condition clarity
CelineWuest Dec 10, 2023
54269a6
Fix if condition
CelineWuest Dec 15, 2023
5962af9
Added test
CelineWuest Dec 15, 2023
3105987
Add credit in draftlog
CelineWuest Dec 15, 2023
2d81fdf
Change target node in test
CelineWuest Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix 6328 - Hovering over Sankey node highlights all full traces
  • Loading branch information
@CelineWuest
CelineWuest committed Nov 27, 2023
commit 81998ac729f47c87c9cf482be4cfa15c5bb7ad36
43 changes: 23 additions & 20 deletions src/traces/sankey/plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,24 +62,25 @@ function nodeNonHoveredStyle(sankeyNode, d, sankey) {
}

function linkHoveredStyle(d, sankey, visitNodes, sankeyLink) {
var label = sankeyLink.datum().link.label;

sankeyLink.style('fill-opacity', function(l) {
if(!l.link.concentrationscale) {
return 0.4;
}
});

if(label) {
ownTrace(sankey, d)
.selectAll('.' + cn.sankeyLink)
.filter(function(l) {return l.link.label === label;})
.style('fill-opacity', function(l) {
if(!l.link.concentrationscale) {
return 0.4;
}
});
}
sankeyLink.each((curLink => {
var label = curLink.link.label;
if(label) {
ownTrace(sankey, d)
.selectAll('.' + cn.sankeyLink)
.filter(function(l) {return l.link.label === label;})
.style('fill-opacity', function(l) {
if(!l.link.concentrationscale) {
return 0.4;
}
});
}
}))

if(visitNodes) {
ownTrace(sankey, d)
Expand All @@ -90,15 +91,17 @@ function linkHoveredStyle(d, sankey, visitNodes, sankeyLink) {
}

function linkNonHoveredStyle(d, sankey, visitNodes, sankeyLink) {
var label = sankeyLink.datum().link.label;

sankeyLink.style('fill-opacity', function(d) {return d.tinyColorAlpha;});
if(label) {
ownTrace(sankey, d)
.selectAll('.' + cn.sankeyLink)
.filter(function(l) {return l.link.label === label;})
.style('fill-opacity', function(d) {return d.tinyColorAlpha;});
}

sankeyLink.each(curLink => {
var label = curLink.link.label;
if(label) {
ownTrace(sankey, d)
.selectAll('.' + cn.sankeyLink)
.filter(function(l) {return l.link.label === label;})
.style('fill-opacity', function(d) {return d.tinyColorAlpha;});
}
})

if(visitNodes) {
ownTrace(sankey, d)
Expand Down