-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add new traces: scattermap
, choroplethmap
and densitymap
which use maplibre
to render maps
#7060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
155 commits
Select commit
Hold shift + click to select a range
d59264f
Install maplibre
birkskyum 54408b2
migrate to maplibre
birkskyum e30f3b0
remove index file
birkskyum a8a5416
use prod build
birkskyum 7e15adf
remove the mapbox token
birkskyum 720f1d8
remove mapbox token
birkskyum 0dd739d
lint
birkskyum 32deaba
update expected schema
birkskyum d509764
remove maplibre logo addition
birkskyum 5ebf050
lint
birkskyum 998e548
fix maplibre style var naming
birkskyum e6408a1
lint
birkskyum 0f323f2
lint
birkskyum a136a89
fix the built in style glyphs
birkskyum cb59be1
maplibre doesn't need credentials
birkskyum 5229cd5
Revert "fix the built in style glyphs"
birkskyum 15ae076
fix extrabold fonts
birkskyum 941952f
add missing closing braces
birkskyum 03c64e3
lint
birkskyum 688d210
changelog
birkskyum e07d60a
add maplibre-gl to webpack config
birkskyum a789a26
reduce the diff to a minimum - keep mapbox naming in traces
birkskyum e239623
ci
birkskyum 54fc455
reduce diff
birkskyum 87c89e5
reduce diff
birkskyum 84758fa
reduce diff
birkskyum 77ddb35
reduce diff
birkskyum 8042130
typo
birkskyum 153169b
use change file instead of changelog
birkskyum 5bf848b
reduce diff
birkskyum 23aba28
reduce diff
birkskyum d46c5c5
reduce diff
birkskyum 24b95c1
trim lines
birkskyum 2a04b4f
reduce diff
birkskyum 2c4c949
revert mocks
birkskyum 6d04f0b
remove open sans extrabold font fix from this pr
birkskyum 01b54da
Merge branch 'master' into maplibre
birkskyum ad1cd31
remove maplibre fox webpack
birkskyum 68dd920
fix open sans extrabold
birkskyum 9982cf9
add to blacklist
birkskyum 805270c
fix open sans font
birkskyum fe51207
Noto Sans Regular
birkskyum 5c57f0d
remove console.log
birkskyum b645866
fix layout check race condition
birkskyum 7cd4e85
remove blacklists
birkskyum 9ecc9ad
add back blacklist
birkskyum 3386006
adjust blacklist
birkskyum 923375a
make lint-fix pass no-es6 check
birkskyum 7cd3177
update baselines
birkskyum c2663ed
revert mocks
birkskyum 95e4206
define mapbox style keywords
birkskyum 099ee56
use vector styles
birkskyum 962774e
add styles
birkskyum 2f5aa98
add nolabels and voyager style
birkskyum 014e063
sat
birkskyum 2b5bf15
fixed the extrabold issue in mapbox_fonts-supported-open-sans-weight …
birkskyum 9cd8406
add extra styles
birkskyum b2873b5
update plot-schema
birkskyum 3a3ee24
lint
birkskyum bbcfe39
bais
birkskyum 6ca6748
blacklist custom style
birkskyum f05189f
blacklist gl2d_heatmapgl
birkskyum 36fe51d
add error desc to gl2d
birkskyum 1ebdb38
remove api keys from stamen
birkskyum 0e3ac61
cleanup style loading
birkskyum a3c5f40
cleanup getStyle
birkskyum 408d362
blacklist gl2d_heatmapgl_discrete , memory issue
birkskyum af5745b
update baselines
birkskyum ad43fff
use voyager for streets
birkskyum d33c8ea
have labels by default
birkskyum 1a12460
nolabels
birkskyum cd2ac06
adjust defualt
birkskyum 1a79b82
update baseline
birkskyum a845821
remove mapbox from blacklist
birkskyum 72cef73
use sat
birkskyum 0bfbfcd
blacklist stamen
birkskyum 7ce0a68
fix attribution tests
birkskyum 986dd55
update custom style
birkskyum 2eacc32
osm style
birkskyum d5411fa
add gl2d to blacklist
birkskyum 7a2c98f
remove
birkskyum 8839f4c
add
birkskyum 48fb8d6
remove special cases found in compare_pixels_test.js
birkskyum 8da4c5d
update baselines
birkskyum c6c2ef7
remove filter of mock
birkskyum ff3b9ee
remove skipping blacklist
birkskyum 53478d9
lint
birkskyum f74cb08
increase parallelism for baseline creation
archmoj fd50eb5
small baselines updates related to change of order of rendering
archmoj 6540ade
revisit blacklist in compare_pixels_test.js
archmoj 97f8898
Use url in style
birkskyum 84cf02e
nolabel
birkskyum 4125395
Bump to maplibre-gl 4.4.0 and use unminified prod build
birkskyum 1b62417
Merge remote-tracking branch 'origin/master' into maplibre
birkskyum fd53631
disable tests
birkskyum 17f4324
fix choropleth jasmine test
birkskyum d35eb4c
fix densitymapbox jasmine test
birkskyum 5733a95
fix some mapbox jasmine tests
birkskyum fcfb09b
fix mapbox scroolZoom test
birkskyum 310fdef
maplibre is more strict, protecting against invalid sources and layers
birkskyum 3cf4f9d
disable test due to incorrect mock
birkskyum 258998a
update expectations due to Carto style
birkskyum 2e5f8f9
rehover mapbox test
birkskyum 510fa26
lint
birkskyum dd4cb63
show errors in ci
birkskyum 8a7b84c
fix layer indexes
birkskyum d718685
remove fit
birkskyum a408f14
lint
birkskyum 961c747
remove comment
birkskyum db36596
fix 'should be able to add, update and remove layers'
birkskyum 871c2d3
don't fit
birkskyum 9a36cf6
lint
birkskyum 1308cbe
add clean function to mapbox plot
birkskyum 0116b21
add addition to scrollZoom test
birkskyum 070941e
remove fit()
birkskyum f5e471c
Drop test_image from noci task
birkskyum 240a392
Drop test_image from noci task
birkskyum d09cdd4
Merge remote-tracking branch 'origin/master' into add-maplibre-option
archmoj ee406f7
update baselines
archmoj 4710fba
find and replace mapbox with mapnew
archmoj f2c361d
rename file names
archmoj 4c2196a
rename mocks and baselines
archmoj 522fd13
rename jasmine tests
archmoj 649122e
baselines without mapbox in their name & title
archmoj 4770657
bring back mapbox files
archmoj e173ca8
bring back mapbox mocks and baselines
archmoj 047ed33
bring back mapbox tests
archmoj 0efeb15
bring back mapbox in various places
archmoj 9a2db69
revise blacklist
archmoj 779ee24
adjust parallelism for baselines
archmoj 6d86a42
update baselines with new order on CI
archmoj 827b9a6
adjust jasmine tests
archmoj 5f0e9e7
bump maplibre-gl v4.5.0
archmoj a1ea0bc
find & replace mapnew > map
archmoj 760ecd3
rename files mapnew > map
archmoj b261c19
map* tests also includes mapbox now
archmoj 4101e40
adjust duplicate map variables in map_test
archmoj f3998ac
adjust map_test to run locally
archmoj e0dfa44
update schema
archmoj 929be3f
add flaky for some map baselines
archmoj 6b56217
load maki icon
birkskyum 7e743c5
requestedIcons
birkskyum 2fb79ac
lint
birkskyum d7f467e
update baselines maki icons
birkskyum fb0f1cc
add map_angles to isOtherFlaky
birkskyum 096b347
Merge pull request #7068 from birkskyum/load-maki-icons
archmoj 5fc241b
separate hasMapbox and hasMap
archmoj c8f5702
refactor compare_pixels_test
archmoj 1dd8c0e
test map not mapbox in new modebar_test
archmoj 5e3d3fe
use url for custom style for map
archmoj 6a46b43
show labels for light and dark styles similar to mapbox
archmoj 530064c
update map_angles.png
archmoj abe9389
map_angles is more flaky
archmoj 6794fbd
update map_angles.png
archmoj d704f71
no need for requiredVersion in src/plots/map/constants.js
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rename files mapnew > map
- Loading branch information
commit 760ecd369c1978f448cde88be52200ba9af20b51
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
emilykl marked this conversation as resolved.
Show resolved
Hide resolved
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archmoj This one looks incorrect to me -- mapbox_layers.png renders a red polygon outline on the left map.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify, that polygon came from mapbox's terrain endpoint - i didn't have a replacement data source. Also, maplibre has a more flexible way to drawing contour lines, which is the recommendation, where you can set the breakpoints, labels etc. - https://maplibre.org/maplibre-gl-js/docs/examples/contour-lines/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilykl Good catch!
@birkskyum Thanks for the note. Would you please open a PR to fix rendering of this polygon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archmoj , as mentioned, I don't have a replacement data source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@birkskyum Is there a way to modify the new maplibre mock to display the polygon?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can extract the geojson with the vertices of the polygon, then it's possible to draw it with plotly/maplibre.