Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump madge 6 -> 8 #7114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Bump madge 6 -> 8 #7114

merged 1 commit into from
Aug 19, 2024

Conversation

birkskyum
Copy link
Contributor

Adds support for node 20, min. supported version is node 18.

Changelog

@archmoj
Copy link
Contributor

archmoj commented Aug 19, 2024

In which file it is required?

@birkskyum
Copy link
Contributor Author

Only in test_syntax.js

@archmoj
Copy link
Contributor

archmoj commented Aug 19, 2024

Is test_syntax.js still used after biome changes?

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 19, 2024

It's executed from the .circleci/test.sh -> test-syntax -> node tasks/test_syntax.js

@archmoj
Copy link
Contributor

archmoj commented Aug 19, 2024

Ok. I see that's useful for catching circular dependencies.

@archmoj archmoj merged commit d5682f8 into plotly:master Aug 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants