Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop support for passing a string to the title attribute, and drop support for deprecated attributes titlefont, titleposition, titleside, and titleoffset #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 9, 2024
Merged

Drop support for passing a string to the title attribute, and drop support for deprecated attributes titlefont, titleposition, titleside, and titleoffset #7212

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e54e65c
remove support for 'title' as string, and remove 'titlefont', 'titles…
emilykl Oct 4, 2024
5cfe400
update plot-schema
emilykl Oct 4, 2024
174ec01
update jasmine tests
emilykl Oct 4, 2024
d1a5f09
update jasmine tests
emilykl Oct 4, 2024
e3d5abb
remove deprecated title attributes from colorbar
emilykl Oct 4, 2024
0f2fde9
update plot-schema
emilykl Oct 4, 2024
753858a
remove test for removed attribute
emilykl Oct 7, 2024
b4d2bef
update jasmine tests
emilykl Oct 7, 2024
c0c64f6
draftlog
emilykl Oct 7, 2024
e948ff4
fix test
emilykl Oct 7, 2024
cc5b9f9
remove empty '_deprecated' keys
emilykl Oct 7, 2024
26129d9
update plot-schema
emilykl Oct 7, 2024
8a0362d
merge master
emilykl Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove deprecated title attributes from colorbar
  • Loading branch information
@emilykl
emilykl committed Oct 4, 2024
commit e3d5abbadc6c476687c36439bfdd5dd1cebbd765
32 changes: 2 additions & 30 deletions src/components/colorbar/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,19 +212,10 @@ module.exports = overrideAll({
title: {
text: {
valType: 'string',
description: [
'Sets the title of the color bar.',
'Note that before the existence of `title.text`, the title\'s',
'contents used to be defined as the `title` attribute itself.',
'This behavior has been deprecated.'
].join(' ')
description: 'Sets the title of the color bar.'
},
font: fontAttrs({
description: [
'Sets this color bar\'s title font.',
'Note that the title\'s font used to be set',
'by the now deprecated `titlefont` attribute.'
].join(' ')
description: 'Sets this color bar\'s title font.'
}),
side: {
valType: 'enumerated',
Expand All @@ -234,29 +225,10 @@ module.exports = overrideAll({
'with respect to the color bar.',
'Defaults to *top* when `orientation` if *v* and ',
'defaults to *right* when `orientation` if *h*.',
'Note that the title\'s location used to be set',
'by the now deprecated `titleside` attribute.'
].join(' ')
}
},

_deprecated: {
title: {
valType: 'string',
description: [
'Deprecated in favor of color bar\'s `title.text`.',
'Note that value of color bar\'s `title` is no longer a simple',
'*string* but a set of sub-attributes.'
].join(' ')
},
titlefont: fontAttrs({
description: 'Deprecated in favor of color bar\'s `title.font`.'
}),
titleside: {
valType: 'enumerated',
values: ['right', 'top', 'bottom'],
dflt: 'top',
description: 'Deprecated in favor of color bar\'s `title.side`.'
}
}
}, 'colorbars', 'from-root');