Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop support for deprecated error bar opacity attribute (use alpha channel of error bar color attribute instead) #7216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Drop support for deprecated error bar opacity attribute (use alpha channel of error bar color attribute instead) #7216

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
64997cc
drop deprecated error bar 'opacity' attribute (use alpha channel of e…
emilykl Oct 7, 2024
019646d
fix typo
emilykl Oct 7, 2024
dd70bac
update mock
emilykl Oct 7, 2024
d9bbe2e
add draftlog
emilykl Oct 7, 2024
3dbb5a5
update plot-schema
emilykl Oct 7, 2024
51ea85b
include error bar opacity in mock
emilykl Oct 8, 2024
c02d508
update error bar style baseline
emilykl Oct 8, 2024
1e8cd59
merge master
emilykl Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
drop deprecated error bar 'opacity' attribute (use alpha channel of e… 
…rror bar 'color' attribute instead)
  • Loading branch information
@emilykl
emilykl committed Oct 7, 2024
commit 64997cce693145730a0b11ff28b87b690eb231ec
11 changes: 0 additions & 11 deletions src/components/errorbars/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,4 @@ module.exports = {
].join(' ')
},
editType: 'calc',

_deprecated: {
opacity: {
valType: 'number',
editType: 'style',
description: [
'Obsolete.',
'Use the alpha channel in error bar `color` to set the opacity.'
].join(' ')
}
}
};
12 changes: 0 additions & 12 deletions src/plot_api/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,18 +283,6 @@ exports.cleanData = function(data) {
delete trace.xbins;
}

// error_y.opacity is obsolete - merge into color
if(trace.error_y && 'opacity' in trace.error_y) {
var dc = Color.defaults;
var yeColor = trace.error_y.color || (traceIs(trace, 'bar') ?
Color.defaultLine :
dc[tracei % dc.length]);
trace.error_y.color = Color.addOpacity(
Color.rgb(yeColor),
Color.opacity(yeColor) * trace.error_y.opacity);
delete trace.error_y.opacity;
}

// convert bardir to orientation, and put the data into
// the axes it's eventually going to be used with
if('bardir' in trace) {
Expand Down