Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set key function for layout images #7277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Set key function for layout images #7277

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c707b2
set key function for layout images
alexcjohnson Nov 20, 2024
e18ffd6
ensure images stay sorted properly with the new data key
alexcjohnson Nov 20, 2024
8b41fd6
test layout image identity
alexcjohnson Nov 21, 2024
bed729e
changelog for layout image identity fix
alexcjohnson Nov 21, 2024
5b94536
exclude CITATION.cff from lowercase filename test
alexcjohnson Nov 21, 2024
58c69e9
also key and sort subplot images
alexcjohnson Nov 21, 2024
148c693
fix image transition test - but why does it work?
alexcjohnson Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
set key function for layout images
  • Loading branch information
@alexcjohnson
alexcjohnson committed Nov 20, 2024
commit 8c707b2009972cc160d268b8c4b85842578b12c3
8 changes: 6 additions & 2 deletions src/components/images/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,14 @@ module.exports = function draw(gd) {
);
}

function imgDataFunc(d) {
return [d.xref, d.x, d.sizex, d.yref, d.y, d.sizey].join('_');
}

var imagesBelow = fullLayout._imageLowerLayer.selectAll('image')
.data(imageDataBelow);
.data(imageDataBelow, imgDataFunc);
var imagesAbove = fullLayout._imageUpperLayer.selectAll('image')
.data(imageDataAbove);
.data(imageDataAbove, imgDataFunc);

imagesBelow.enter().append('image');
imagesAbove.enter().append('image');
Expand Down