Add eventData handler to heatmap for proper click event data#7686
Open
nojaf wants to merge 3 commits intoplotly:masterfrom
Open
Add eventData handler to heatmap for proper click event data#7686nojaf wants to merge 3 commits intoplotly:masterfrom
nojaf wants to merge 3 commits intoplotly:masterfrom
Conversation
Collaborator
|
Thanks @nojaf - your fix looks plausible, though I'm a little surprised this hasn't come up before. Can you make one or two standalone examples (in codepen preferably) that show the bugs this fixes? Then we can swap between using the latest release version and the build from your PR, which is available as a CI artifact here |
Author
|
Hi @alexcjohnson, I've been investigating further and I'm no longer sure the problem is in Plotly. It might be in the Marimo integration layer. I tried reproducing the issue with raw Plotly and react-plotly, but couldn't recreate what I see in Marimo notebooks. I'll keep digging. If you don't hear from me within a week, feel free to close both the PR and the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7685
This PR adds an
eventDatahandler to the heatmap trace module, enabling properplotly_clickevent data withx,y, andzvalues.Also fixes a bug in
hover.jswhere category axis labels were incorrectly returning numeric boundary values instead of the actual category labels.Changes:
src/traces/heatmap/index.js- Register the eventData handlersrc/traces/heatmap/event_data.js- New file implementing the event data extractionsrc/traces/heatmap/hover.js- Fix category axis label lookup to use `xa._categories[nx]