Decircularise a few things #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by adding a `snapshot/helpers.js` module
by:
- removing add require('plotly'),
- adding an index file, and
- require the polar index in plot_api.js
| }; | ||
|
|
||
| var extendDeepAll = Plotly.Lib.extendDeepAll; | ||
| var µ = module.exports = { version: '0.2.2' }; |
There was a problem hiding this comment.
Why use µ when we could use this instead?
|
🎉 🎉 🎉 🎉 💃 🎉 🎉 🎉 🎉 |
by: - not requiring Lib into plot_config.js to log error - rm useless Lib.log in lib/dates.js - require lib/loggers.js directly instead of Lib in lib/search.js
by:
- making modebar/index.js require what needs to be exposed
for other parts of the code
- in consequence old modebar/index.js -> modebar/modebar.js
- var ModeBar = require('modebar/') and use ModeBar.manage
in plot_api.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... a few steps towards (finally) fixing #236
In brief this PR:
Plotly[module][method]()pattern. When the modules in question are free of circular dependency patterns, require modules directly instead ofsrc/plotly.js.src/snapshot/so that it is free of circular dependency patternssrc/plots/polar/( 🎉 ) so that it is free of circular dependency patternslib/, namelyloggers.js,dates.jsandsearch.jsto free it from circular dependenciescomponents/modebar/to make it more consistent with other components (and eventually more easily registrable).