'XAxis' object has no attribute '_gridOnMajor' #2913

tssweeney · 2020-11-18T20:32:22Z

Hello, matplotlib recently merged a change that removed provide variables from Axis: matplotlib/matplotlib#18769. There are at least 2 places in plotly code that reference these variables:

plotly.py/packages/python/plotly/plotly/matplotlylib/mplexporter/utils.py

Line 246 in 65625d4

if axis._gridOnMajor and len(gridlines) > 0:

,

plotly.py/packages/python/plotly/plotly/matplotlylib/mplexporter/renderers/base.py

Line 21 in 65625d4

return bool(ax and ax.xaxis._gridOnMajor and ax.yaxis.get_gridlines())

, and

plotly.py/packages/python/plotly/plotly/matplotlylib/mplexporter/renderers/base.py

Line 25 in 65625d4

return bool(ax and ax.yaxis._gridOnMajor and ax.yaxis.get_gridlines())

In particular I hit this bug when converting matplotlib to pyplot.

matplotlib>=3.3.3
plotly>=4.12.0

Repro:

import plotly
import matplotlib.pyplot as plt

fig = plt.figure(1)
ax = plt.plot([1,2,3])
plotly.tools.mpl_to_plotly(fig)

results in

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-3-c2ca21d8fe91> in <module>()
      1 fig = plt.figure(1)
      2 ax = plt.plot([1,2,3])
----> 3 plotly.tools.mpl_to_plotly(fig)

6 frames
/usr/local/lib/python3.6/dist-packages/plotly/matplotlylib/mplexporter/utils.py in get_grid_style(axis)
    244 def get_grid_style(axis):
    245     gridlines = axis.get_gridlines()
--> 246     if axis._gridOnMajor and len(gridlines) > 0:
    247         color = export_color(gridlines[0].get_color())
    248         alpha = gridlines[0].get_alpha()

AttributeError: 'XAxis' object has no attribute '_gridOnMajor'

FWIW, i think the fix is to replace these calls with _major_tick_kw['gridOn'].

Thank you,
Tim

The text was updated successfully, but these errors were encountered:

nicolaskruchten · 2020-11-19T01:47:25Z

Thanks for the detailed bug report! We're not really actively maintaining the matplotlib to Plotly system any more to be honest, so this kind of "rot" is a bit to be expected. We would probably accept a pull request if it's backwards-compatible though!

fix mpld3/mpld3#479, see plotly/plotly.py#2913

tssweeney · 2020-11-19T20:28:23Z

Thanks @nicolaskruchten for getting back to me. Also @carlinmack for submitting a quick fix. I would appreciate the merge if/when tests pass! (:

carlinmack · 2020-11-19T20:30:23Z

oh sorry that's in a different repository that has the same issue! It's a really simple fix though (axis._gridOnMajor -> axis._major_tick_kw['gridOn']) and the lines are listed above. I could fix it, but I don't have reference code to test with (I've never used plotly!)

…ntained anymore, see this issue plotly/plotly.py#2913

* update notebooks * remove metadata from cells during tests * update content and contextily installation * add descartes * typo * update installation manual * update gitignore * move groundwater model directory * update gitignore * restructure and update practical examples * last update for now * add cbs_data analyse * update twitter analysis * reinstate some files to be ignored * remove error in camel_bananas function * update camel problem * modify text * remove notebook metadata as well (and not only cell metadata) * minor changes * remove all metadata from notebooks * add on-topic to test * update travis requirements * fix travis test errors * add pyproj to travis req * add proj to travis req * add proj4 to travis req * remove proj from req * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another attempt to let travis install cartopy * another day another attempt: * another day another attempt: * another day another attempt: * another day another attempt: * add dependencies * add dependency * remove first folium notebook from tests because mplleaflet is not maintained anymore, see this issue plotly/plotly.py#2913

kr-hansen · 2020-12-09T20:21:07Z

Any update on this? Looks like it may have been added, but doesn't look like a pull request was accepted yet? Did somebody do this yet?

If not I'm happy to go to the locations highlighted by @tssweeney and put the line that @carlinmack suggested to submit a pull request.

…tly.py#2913

gvwilson · 2024-06-24T15:59:22Z

Hi - we are trying to tidy up the stale issues and PRs in Plotly's public repositories so that we can focus on things that are still important to our community. Since this one has been sitting for several years, I'm going to close it; if it is still a concern, please add a comment letting us know what recent version of our software you've checked it with so that I can reopen it and add it to our backlog. Thanks for your help - @gvwilson

carlinmack mentioned this issue Nov 19, 2020

XAxis' object has no attribute '_gridOnMajor mpld3/mpld3#479

Closed

carlinmack added a commit to carlinmack/mplexporter that referenced this issue Nov 19, 2020

Fix major axis grid on condition

739793f

fix mpld3/mpld3#479, see plotly/plotly.py#2913

mmourafiq mentioned this issue Nov 19, 2020

New matplotlib breaking change polyaxon/polyaxon#1172

Closed

jklymak mentioned this issue Nov 26, 2020

Need a way to check if an axis minor or major grid is on matplotlib/matplotlib#19021

Open

OnnoEbbens added a commit to MAMBA-python/course-material that referenced this issue Dec 2, 2020

remove first folium notebook from tests because mplleaflet is not mai…

edcf081

…ntained anymore, see this issue plotly/plotly.py#2913

kamil-kaczmarek mentioned this issue Dec 8, 2020

Dev/sklearn neptune-ai/neptune-contrib#119

Merged

Derek-Wds mentioned this issue Jan 6, 2021

Update docs and add Python 3.9 CI microsoft/qlib#178

Merged

5 tasks

0xtristan pushed a commit to sholtodouglas/learning_from_play that referenced this issue Feb 3, 2021

Changed matplotlib and plotly version to avoid current bug plotly/plo…

7f4c7d0

…tly.py#2913

alexlenail mentioned this issue Aug 17, 2021

Support matplotlib > 3.3.2 deeptools/pyGenomeTracks#356

Closed

22tommibaer01 mentioned this issue Oct 20, 2021

mplleaflet AttributeError: 'XAxis' object has no attribute '_gridOnMajor' jwass/mplleaflet#80

Open

WouterNieuwerth mentioned this issue Nov 12, 2021

Same fix as described in other repos with the same bug. jwass/mplexporter#1

Open

xiaosuqi1778 mentioned this issue Dec 4, 2023

总结一下我使用该项目遇到的问题及解决办法 JoanMartin/trackanimation#20

Closed

gvwilson closed this as completed Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

'XAxis' object has no attribute '_gridOnMajor' #2913

'XAxis' object has no attribute '_gridOnMajor' #2913

tssweeney commented Nov 18, 2020

nicolaskruchten commented Nov 19, 2020

Uh oh!

tssweeney commented Nov 19, 2020

Uh oh!

carlinmack commented Nov 19, 2020 •

edited

Loading

Uh oh!

kr-hansen commented Dec 9, 2020

Uh oh!

gvwilson commented Jun 24, 2024

Uh oh!

Uh oh!

'XAxis' object has no attribute '_gridOnMajor' #2913

'XAxis' object has no attribute '_gridOnMajor' #2913

Comments

tssweeney commented Nov 18, 2020

nicolaskruchten commented Nov 19, 2020

Uh oh!

tssweeney commented Nov 19, 2020

Uh oh!

carlinmack commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kr-hansen commented Dec 9, 2020

Uh oh!

gvwilson commented Jun 24, 2024

Uh oh!

carlinmack commented Nov 19, 2020 •

edited

Loading