Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix grid url for when plotly_domain is different than plotly_api_domain #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2014
Merged

Fix grid url for when plotly_domain is different than plotly_api_domain #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096073e
Use web_url in response instead of plotly_domain in session\nplotly_d…
chriddyp Dec 11, 2014
a64b172
bump version
chriddyp Dec 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions plotly/plotly/plotly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,15 +840,13 @@ def upload(cls, grid, filename,

response_columns = res['file']['cols']
grid_id = res['file']['fid']
grid_url = res['file']['web_url']

# mutate the grid columns with the id's returned from the server
cls._fill_in_response_column_ids(grid, response_columns, grid_id)

grid.id = grid_id

plotly_domain = get_config()['plotly_domain']
grid_url = '{0}/~{1}'.format(plotly_domain, grid_id.replace(':', '/'))

if meta is not None:
meta_ops.upload(meta, grid=grid)

Expand Down
2 changes: 1 addition & 1 deletion plotly/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '1.4.8'
__version__ = '1.4.9'