Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Session module #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 26, 2015
Merged

Session module #186

merged 7 commits into from
Feb 26, 2015

Conversation

theengineear
Copy link
Contributor

This factors out the common _config/_credentials/_plot_options from plotly.py into a new session.py module which is meant to not rely on other plotly modules such that all modules can safely import it to know what the current session-status is.

@theengineear
Copy link
Contributor Author

@chriddyp and @etpinard , this also fixes a problem that occurs when you sign-in to a different plotly domain... Since tools.embed uses the file-config, what gets embedded was not matching what was iplotted! yikes!

@etpinard
Copy link
Contributor

etpinard commented Feb 2, 2015

Inspired by Lightning-viz ?

@theengineear
Copy link
Contributor Author

nah, this is something i've been meaning to refactor for a while now. it should be a better way to stay organized.

@theengineear
Copy link
Contributor Author

thx! i'll wait for the tests and merge it in.

@etpinard
Copy link
Contributor

etpinard commented Feb 2, 2015

Cool. 💃 on my end.

theengineear added a commit that referenced this pull request Feb 26, 2015
@theengineear theengineear merged commit 992c807 into master Feb 26, 2015
@theengineear theengineear deleted the session-module branch February 26, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants