Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Circle pyenv #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 13, 2015
Merged

Circle pyenv #204

merged 32 commits into from
Mar 13, 2015

Conversation

theengineear
Copy link
Contributor

Just some fun with circle:

  • circle didn't have the pyenv shims ahead of the system python binary's path therefore, even though we were setting up pyenv right, it was still using python 2.7 to run the majority of our test suite
  • we thought it was working because the variables were set right and we even got python 2.6- and python 3.x-specific errors because we we're still catching the general module import test.

@theengineear
Use pyenv global to set version.
dacf4c3
@theengineear
explicitly use current python to show version
f8af6da
@theengineear
attempt to set pyenv locally as well…
4c45757
@theengineear
attempt to use pyenv shell to set version.
4abfbe3
@theengineear
ok, all levels of pyenv are now set…
af527ab
@theengineear
Revert "ok, all levels of pyenv are now set…"
382cf6c 
This reverts commit af527ab.
@theengineear
Revert "attempt to use pyenv shell to set version."
4d22b0f 
This reverts commit 4abfbe3.
@theengineear
Revert "attempt to set pyenv locally as well…"
087ee62 
This reverts commit 4c45757.
@theengineear
Revert "Use pyenv global to set version."
f25a603 
This reverts commit dacf4c3.
@theengineear
serve up some additional info in circle
ed6860b
@theengineear
Ensure that shims for PYENV are first in path!
8bba7d3
@theengineear
No need to set PYENV_VERSION for system.
cf8048a 
Since each command runs in a new shell, and the path looks for system
Python *first*, setting PYENV_VERSION here doesn’t even do anything.
It was looking at the system Python 2.7 because that’s the default
`python` bin.
@theengineear
just override dependencies, don’t bother with pre
7c3bac6
@theengineear
fix skipIf python 2.6 test failure.
26b1b51
@theengineear
Introduce more flexible strict JSON implementation
64b8abb 
The previous version was impossible to maintain across different json
versions.
@theengineear
safely import simplejson for python 2.6
a912e2a
@theengineear
Try to cache all the hard work done in deps.
785c723 
Circle seems to trash the things installed in the pyenv environments…
@theengineear
Fix Python 3 attribute error in test.
a7aa45f
@theengineear
print(x) vs print x fix for python 3.
42a7dd8
@theengineear
Removed confusing (unnecessary?) test assertion.
68999fe
@theengineear
0 prefix not allowed in python 3 apparently.
0f2777b
@theengineear
floats serialize to a different precision in py3
8734384
@theengineear
number of significant digits seems to have changed
dee8d27 
the only thing i can imagine is that python treats an iterable
differently when it’s not homogenous (now that we don’t have `NaN`)
anymore for example in otherwise float-y arrays.
@theengineear
compare python obj, not serialization.
2b73659
@theengineear
protect skip import
7345c14
@theengineear
protect widgets import in test (python 2.6)
37ac31a
@theengineear
assertListEqual DNE in python 2.6 TestCase
4792e62
@theengineear
no set literals : (
f020ae9
@theengineear
assertIs DNE in python 2.6 TestCase
3e39f32
@theengineear
Copy link
Contributor Author

@chriddyp , look ok to you?

@chriddyp
Copy link
Member

wow, good catch! 💃

theengineear added a commit that referenced this pull request Mar 13, 2015
@theengineear
Merge pull request #204 from plotly/circle-pyenv
7d27874 
Circle pyenv
@theengineear theengineear merged commit 7d27874 into master Mar 13, 2015
@theengineear theengineear deleted the circle-pyenv branch March 13, 2015 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theengineear @chriddyp