-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[Deprecated] Starting AI/ML section in python docs #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @xhlulu thanks for the pull request :-). Doc tutorials need to have a header with information from jupytext and some meta-data about the tutorial. See for example the header of https://raw.githubusercontent.com/plotly/plotly.py/master/doc/python/line-and-scatter.md. I'm surprised that there is no header at all did you edit the file in the notebook? jupyter/jupytext should have created one. |
Thanks @emmanuelle for the review! I added your suggestions to the notebook. Here's an overview of what I also changed: "i split the knn into two notebooks; one for regression (didn't touch it further, just a placeholder notebook), and added 4 sections to the knn notebook. Now it has two "simple" sections that takes less than 20 lines, and 2 more "advanced vis" for 3D and splom viz" |
Some things I am stuck on:
For the header, here's what it currently looks like: https://github.com/plotly/plotly.py/pull/2172/files/70f7131b939e4396b46405b02e42b3914c9bdfe7# |
Good questions! @jdamiba shouls be able to steer you in the right direction :) |
The So if the The You don't need to create the ML section, I took care of that in plotly/graphing-library-docs#9. Just make sure to set Here are the instructions for uploading a thumbnail image. Once the image is uploaded, you set
I'm not sure how to create a new notebook with the right header- I would suggest just copy and pasting the header from another example and modifying it. Maybe @emmanuelle has a better idea? You can also try creating the notebook in Jupyter if you get the Jupytext extension. Let me know if you have any other questions or if any of this wasn't clear! |
@jdamiba Wow! Thank you for the super detailed answer! I'll be working on this friday/saturday. Just a question: does |
Order actually starts at 1, so you want to use 1, 2, 3, and 4 for the pages you want to show up on the landing page, and 6, 7, 8, ..., N for the rest. No page that you create in this repo should have order 5, as that is reserved for use by the category index page in the |
|
||
df = px.data.tips() | ||
X = df.total_bill.values.reshape(-1, 1) | ||
X_train, X_test, y_train, y_test = train_test_split(X, df.tip, random_state=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing set is not used for any testing here so I'm not sure I understand the goal of this example.
x0=y.min(), y0=y.min(), | ||
x1=y.max(), y1=y.max() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x0=y.min(), y0=y.min(), | |
x1=y.max(), y1=y.max() | |
x0=0, y0=0, | |
x1=y.max(), y1=y.max() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a very minor aesthetic point, but it looks nicer I think when going through (0, 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make the example as generic as possible, since the user might want to use a y value that could be negative as well.
@emmanuelle thank you for all the suggestions! I just want to first draft out the other notebooks, then address your reviews :) |
Moved to #2276 |
Moved to here: #2276
Please refer to: #2153
Changes:
Todo list: