-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix failing test and refact to TestCase. #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chriddyp once tests are passing again, i'm going to go ahead and merge this into master so you can pull the fix into your offline mode branch. |
@chriddyp seems to be a random failure in python 2.6? also, looks like that version isn't supported at all anymore:
Is is time to ditch 2.6?! w00t? |
huh? did I write that? Sent from my iPhone
|
Ah, I think it might be related to the crypto stuff? https://github.com/pyca/cryptography/blob/master/src/cryptography/__init__.py |
oh hm.. uh.. I guess we'll have to follow suit? pyca/cryptography@0857894#commitcomment-11225855 |
try: | ||
py.file_ops.mkdirs(first_folder) | ||
except PlotlyRequestError as e: | ||
self.assertTrue(400 <= e.status_code < 500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it sort of helpful to know which error code was thrown? I can imagine writing code against a specific error code (e.g. "if conflict, then the folder exists, so don't make a new folder")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i could definitely see that, it's just that i don't think the python library should couple so closely to streambed. this holds for streaming too, we should try and be as transparent about interacting with the plotly apis as possible. i think :)
Also, the 4xx
is like "hey, you did something wrong, you'll need to change your code to fix it", which is much different from 5xx
, "oops, our bad, you might want to try that again later".
@theengineear did you see this guy?
|
re: #238 (comment) yeah, i think that's a python 2.6 thing? i ran all of our tests locally without any failures. |
i'd happily deprecate the use of 2.6. supporting 2.7, 3.3, and 3.4 is much simpler. 2.6 is like 7 years old now. perhaps this can be in our change to 1.7? |
@chriddyp if you're alright with the |
alright, fair enough @theengineear ! but in the future, once the api is out of beta...! |
haha, noted --> #240 |
Fix failing test and refact to TestCase.
@theengineear - dropped 2.6 support in this commit, as not being able to import ipython was biting me in those tests: 08a8660 |
@chriddyp , wonderful, i may make a pr to clean up some other things related to this drop then :) |
Attempting to fix the failing test due to a 409 --> 400 in plotly's /folders endpoint.