Plotly proxy auth #239
Merged
Plotly proxy auth #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lotly-Authorization header for API
| @@ -48,11 +48,15 @@ def warning_on_one_line(message, category, filename, lineno, file=None, line=Non | |||
| # this sets both the DEFAULTS and the TYPES for these items | |||
| _FILE_CONTENT = {CREDENTIALS_FILE: {'username': '', | |||
| 'api_key': '', | |||
| 'proxy_username': '', | |||
| 'proxy_passwd': '', | |||
There was a problem hiding this comment.
could we change to proxy_password?
|
@BRONSOLO sweet dude! think we should add it to |
|
@chriddyp boom - thx for the comments/suggestions. Yeah, I'll add it to |
|
@chriddyp could you take another look through this guy? |
| """Set the keyword-value pairs in `~/.plotly/.config`. | ||
|
|
||
| :param (str) plotly_domain: ex - https://plot.ly | ||
| :param (str) plotly_streaming_domain: ex - https://stream.plot.ly |
There was a problem hiding this comment.
I think this is usually set as stream.plot.ly
|
other than that comment, looks good to me! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chriddyp @theengineear. This allows enterprise users working behind a proxy to specify
Plotly-Authorizationheader as abasic authheader for ourAPI v2. This frees up theAuthorizationheader for the initial proxy layer. For now, it is up to the server admin to handle converting thePlotly-Authorizationheader to the expectedAuthorizationheader for basic auth once authorized over the proxy. In the future, we could simply accept bothPlotly-AuthorizationandAuthorizationheaders in our back end so the server admin won't need to do anything. I added a flag in the config file forplotly_proxy_authorization.todo: