Remove optional requests [security] package. #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests[security] installs pyOpenSSL which installs the latest cryptography. The latest cryptography fails to install on many mac environments with a traceback like: dlopen(/Users/Chelsea/my_project_folder/venv/lib/python2.7/site-packages/cryptography/_Cryptography_cffi_a269d620xd5c405b7.so, 2): Library not loaded: libssl.1.0.0.dylib When [security] is included, anyone upgrading plotly with the common: $ pip install plotly --upgrade or installing plotly fresh from a virtual environment will install the latest cryptography library which has a high liklihood of breaking for mac users. Once cryptography is broken, everything that depends on it, like pip, is also broken, which is difficult to get out of! Hopefully the installation for cryptography on mac is remediable, and we can safely let users upgrade their security when installing plotly.
|
💃 |
chriddyp
added a commit
that referenced
this pull request
Jul 3, 2015
Remove optional requests [security] package.
|
** cryptography isn't actually the issue, looks like it is pyOpenSSL. Here is the issue: pyca/pyopenssl#290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests[security] installs pyOpenSSL which installs the latest cryptography.
The latest cryptography fails to install on many mac environments with a traceback like:
dlopen(/Users/Chelsea/my_project_folder/venv/lib/python2.7/site-packages/cryptography/_Cryptography_cffi_a269d620xd5c405b7.so, 2): Library not loaded: libssl.1.0.0.dylibWhen [security] is included, anyone upgrading plotly with the common:
$ pip install plotly --upgradeor installing plotly fresh from a virtual environment will install the latest cryptography library
which has a high liklihood of breaking for mac users. Once cryptography is broken, everything
that depends on it, like pip, is also broken, which is difficult to get out of!
Hopefully the installation for cryptography on mac is remediable, and we can safely let users
upgrade their security when installing plotly.
cc @cldougl @theengineear @etpinard @aneda