update px colormodel parameter and pytest #2833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm sorry we've not had a chance to review this PR yet, but we might be able to do so this week if you still would like us to... |
|
Thank you for your help! Let me know if you need anything else from me
…On Mon, Nov 23, 2020 at 8:45 AM Nicolas Kruchten ***@***.***> wrote:
Hello,
I'm sorry we've not had a chance to review this PR yet, but we might be
able to do so this week if you still would like us to...
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2833 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGRNVNCOIAWPELDF2POAXW3SRJYQPANCNFSM4SSCUA2A>
.
|
|
Ah well it looks like you force-pushed to |
|
I have recreated a new pull request #2932
<#2932>. Looks like it has problems
in build-doc and python-2.7-optional. Thank you for helping me review the
request!
…On Mon, Nov 23, 2020 at 2:27 PM Nicolas Kruchten ***@***.***> wrote:
Ah well it looks like you force-pushed to master which reset this PR and
closed it, so we'd need you to check out 7b99ee8
<7b99ee8>
and create a branch on that commit and resubmit a PR from there if
possible. If not we can try to cherry-pick those commits :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2833 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGRNVNBRDPAHTZYOFXRACVDSRLATJANCNFSM4SSCUA2A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
added parameter instructions in docstring of imshow function