Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add colormodel parameter into px.imshow and test #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add colormodel parameter into px.imshow and test #2932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08adb0c
add colormodel parameter into px.imshow and test
Nov 24, 2020
de48265
update format of test_imshow using black
Nov 24, 2020
d1d8bbc
use black==19.10b0 to reformat
Nov 24, 2020
9e0d08f
Merge pull request #1 from liudj2008/master
liudj2008 Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/python/plotly/plotly/express/_imshow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def _infer_zmax_from_type(img):

def imshow(
img,
colormodel=None,
zmin=None,
zmax=None,
origin=None,
Expand Down Expand Up @@ -88,6 +89,11 @@ def imshow(
- (M, N, 3): an image with RGB values.
- (M, N, 4): an image with RGBA values, i.e. including transparency.

colormodel: str, 'rgb' or 'hsl' (default 'rgb')
colormodel used to map the numerical color components into colors.
It enables automatic change from rgb/hsl to rgba/hsla depending on
img dimensions.

zmin, zmax : scalar or iterable, optional
zmin and zmax define the scalar range that the colormap covers. By default,
zmin and zmax correspond to the min and max values of the datatype for integer
Expand Down Expand Up @@ -389,7 +395,12 @@ def imshow(
)
trace = go.Image(source=img_str, x0=x0, y0=y0, dx=dx, dy=dy)
else:
colormodel = "rgb" if img.shape[-1] == 3 else "rgba256"
# change colormodel from hsl/rgba to hsla/rgba depending on dimensions
if colormodel == "hsl":
if img.shape[-1] == 4:
colormodel = "hsla"
else:
colormodel = "rgb" if img.shape[-1] == 3 else "rgba"
trace = go.Image(
z=img,
zmin=zmin,
Expand Down
22 changes: 22 additions & 0 deletions packages/python/plotly/plotly/tests/test_core/test_px/test_imshow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,3 +346,25 @@ def test_imshow_hovertemplate(binary_string):
fig.data[0].hovertemplate
== "x: %{x}<br>y: %{y}<br>color: %{z}<extra></extra>"
)


@pytest.mark.parametrize("colormodel", ["rgb", "hsl"])
def test_imshow_colormodel(colormodel):
img_no_alpha = np.array(
[[[147, 50, 47], [147, 50, 47]], [[147, 50, 47], [147, 50, 47]]], dtype=np.uint8
)
img_alpha = np.array(
[
[[147, 50, 47, 0.1], [147, 50, 47, 0.2]],
[[147, 50, 47, 0.3], [147, 50, 47, 1]],
],
dtype=np.uint8,
)
for img in [img_no_alpha, img_alpha]:
fig = px.imshow(img, colormodel=colormodel)
if img.shape[2] == 3:
assert decode_image_string(fig.data[0].source).shape[2] == 3
assert np.all(img_no_alpha == decode_image_string(fig.data[0].source))
else:
assert decode_image_string(fig.data[0].source).shape[2] == 4
assert np.all(img_alpha == decode_image_string(fig.data[0].source))