check that secret graphs are accessible before returning them. #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y aren't accessible, attempt to add the share key again
|
@chriddyp , I caught ya!
Did that error make sense to you when you saw it? Looks like you sorted it out pretty quick. |
|
@theengineear - yup, made sense! |
|
@chriddyp is this meant to be a permanent addition? If it's not, can we add a If this is just a temporary patch, it can 💃 after it's been linked to an issue. I would assume this is a streambed bug, right? |
|
yup, streambed bug. OK, I added the link in that code block. |
|
💃 |
|
💃 |
chriddyp
added a commit
that referenced
this pull request
Oct 6, 2015
check that secret graphs are accessible before returning them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if they aren't accessible, attempt to add the share key again
related to https://github.com/plotly/streambed/issues/4089