Https stream #461
Merged
Https stream #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BRONSOLO I think you need to commit the change to update the |
|
@BRONSOLO and @chriddyp should we update this to https://github.com/plotly/plotly.py/blob/master/circle.yml#L7 |
| @@ -4,6 +4,11 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ## [1.1.0] - 2016-05-16 | |||
| @@ -27,6 +27,7 @@ | |||
| import six.moves | |||
|
|
|||
| from requests.auth import HTTPBasicAuth | |||
| from urlparse import urlparse | |||
There was a problem hiding this comment.
brap. this isn't Python3 compat.
There was a problem hiding this comment.
…to https_stream
|
@theengineear @chriddyp are we good to dance once circle is happy? |
This makes us compatible with Python < 2.7.9 again.
…nto https_stream
|
@theengineear @chriddyp i'm going to bump this version update down to |
Use `TestCase` in `test_stream.py` tests.
…to https_stream
|
|
💃 |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theengineear @chriddyp please review. Required for #457 fix.
related: chriddyp/chunked_requests#7