Colors tests #539
Merged
Colors tests #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - rgb string, hex string or tuple | ||
|
|
||
| """ | ||
| from numbers import Number |
There was a problem hiding this comment.
🐄 imports go at the top of the module.
…surf_plot color in 'data'
| 'width': 800 | ||
| } | ||
| 'data': [{'facecolor': np.array( | ||
| [b'rgb(145.0, 96.0, 143.0)', |
There was a problem hiding this comment.
@Kully remove the b's from here and the dtype='|S23'. You're just being overly-strict in this test. Python 2 and 3 treat str differently and will create a byte or unicode string, respectively.
|
💃 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theengineear
All tests are passing locally. The plan is to slowly replace the code in
toolsby the methods incolors. A renaming of some of the preexisting methods incolors.pywill also be in order, but only after the code intoolsis replaced first.