Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Try tox. #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2017
Merged

Try tox. #645

merged 1 commit into from
Jan 1, 2017

Conversation

theengineear
Copy link
Contributor

I tried using tox looonog ago and it didn't seem to fit our needs for CI. However, I just tried it yesterday again and was able to get a solid setup for our core vs. optional testing needs.

We're considering adding back 2.6 support and having the ability to specify a possibly-different set of deps in tox would be the better option, imo.

See #635

@theengineear
Copy link
Contributor Author

@chriddyp @cldougl @Kully, any objections?

@theengineear
Copy link
Contributor Author

^^ still working on ensuring the base python versions line up correctly. not sure why that's not better documented, pretty important!

@theengineear theengineear force-pushed the try-tox branch 4 times, most recently from 4040564 to edb0487 Compare December 31, 2016 20:42
@theengineear
Copy link
Contributor Author

Man. There's always something... I decided to freeze some deps into our tox tests, which messed up support for Python 3.3 (pandas doesn't seem to like being installed on Python 3.3, I should be able to knock it to core-support-only for Python3.3...).

Also, for whatever reason, accessing 3.5 on Circle CI via environment variables is super painful... I ended up just being absurdly specific about it so that tox/circle don't do any guessing about finding Python interpreters, since they were being bad guessers...

@theengineear theengineear force-pushed the try-tox branch 17 times, most recently from ffe08a5 to 309cfd0 Compare January 1, 2017 19:02
@theengineear
Copy link
Contributor Author

theengineear commented Jan 1, 2017

Woo! Aight, I think we're good to go! I'm shocked that our coverage is above 70% (not too bad, folks!)

I just added one more change to make sure we're explicitly printing out the python version that's being tested (as a sanity check). If that all passes, I'll likely go ahead and merge this in since it only really deals with how tests are run and doesn't change code other than that.

They're not extensive, but I did write up some documentation in contributing.md that might be helpful for understanding our tox setup. It's actually incredibly flexible and while it wasn't the easiest to set up, I think we'll start to profit as we decide we need/want to support more complicated environments in our test suites 🍻.

//cc @chriddyp @Kully @cldougl

@theengineear theengineear merged commit 1f1272d into master Jan 1, 2017
@theengineear theengineear deleted the try-tox branch January 1, 2017 20:06
@chriddyp
Copy link
Member

chriddyp commented Jan 2, 2017

💃 Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants