added force_order param in violin FF #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cldougl could you give this a review when you have a minute or two? |
cldougl
reviewed
May 17, 2017
plotly/figure_factory/_violin.py
Outdated
| @@ -435,6 +440,8 @@ def create_violin(data, data_header=None, group_header=None, colors=None, | |||
| number and will be used to color the violin plots if a colorscale | |||
| is being used. | |||
| :param (bool) rugplot: determines if a rugplot is draw on violin plot. | |||
| :param (bool) forced_order: determines if violins are sorted | |||
There was a problem hiding this comment.
I would probably call this param sort
cldougl
reviewed
May 17, 2017
plotly/figure_factory/_violin.py
Outdated
| @@ -435,6 +440,8 @@ def create_violin(data, data_header=None, group_header=None, colors=None, | |||
| number and will be used to color the violin plots if a colorscale | |||
| is being used. | |||
| :param (bool) rugplot: determines if a rugplot is draw on violin plot. | |||
| :param (bool) forced_order: determines if violins are sorted | |||
| alphabetically (True) or by inputted order (False). | |||
There was a problem hiding this comment.
input order
@Kully can you add defaults to this doc string (like https://github.com/plotly/plotly.py/blob/master/plotly/figure_factory/_distplot.py#L63-L70). It seems a little confusing to list True before False though False is the default
cldougl
reviewed
May 17, 2017
plotly/figure_factory/_violin.py
Outdated
| @@ -627,6 +635,7 @@ def create_violin(data, data_header=None, group_header=None, colors=None, | |||
|
|
|||
| fig = violin_colorscale( | |||
| data, data_header, group_header, valid_colors, | |||
| use_colorscale, group_stats, rugplot, height, width, title | |||
| use_colorscale, group_stats, rugplot, forced_order, height, | |||
plotly/figure_factory/_violin.py
Outdated
| @@ -562,8 +569,7 @@ def create_violin(data, data_header=None, group_header=None, colors=None, | |||
| data = data[data_header].values.tolist() | |||
|
|
|||
| # call the plotting functions | |||
| plot_data, plot_xrange = violinplot(data, fillcolor=valid_colors[0], | |||
| rugplot=rugplot) | |||
There was a problem hiding this comment.
@Kully did you want to take rugplot out of here?
cldougl
reviewed
May 17, 2017
plotly/figure_factory/_violin.py
Outdated
| :param (dict) group_stats: a dictioanry where each key is a unique | ||
| value from the group_header column in data. Each value must be a | ||
| number and will be used to color the violin plots if a colorscale | ||
| is being used. | ||
| :param (bool) rugplot: determines if a rugplot is draw on violin plot. | ||
| Default = True | ||
| :param (bool) sort: determines if violins are sorted. Default = False | ||
| alphabetically (True) or by inputted order (False). |
There was a problem hiding this comment.
@Kully can you put the default at the end, looks like it got added to the middle of the sentence here.
|
💃 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #745