-
Notifications
You must be signed in to change notification settings - Fork 50
Fix links #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links #107
Conversation
@@ -86,44 +86,3 @@ fig <- plot_ly( | |||
|
|||
fig | |||
``` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the big deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it uses maptools
, which looks like it is no longer available.
https://cran.r-project.org/web/packages/maptools/index.html
I don't have enough knowledge of r
to rewrite with these recommended packages.
@@ -22,7 +22,7 @@ knitr::opts_chunk$set(message = FALSE, warning=FALSE) | |||
The bar shows the target value, and the shading represents the progress toward that goal. Gauge charts, known as | |||
speedometer charts as well. This chart type is usually used to illustrate key business indicators. | |||
|
|||
The example below displays a basic gauge chart with default attributes. For more information about different added attributes check [indicator](https://plotly.com/r/indicator/) tutorial. | |||
The example below displays a basic gauge chart with default attributes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this removed.
for (i in tickers){ | ||
getSymbols(i, | ||
from = "2018-01-01", | ||
to = "2019-12-31")} | ||
stock <- data.frame(GOOG$GOOG.Adjusted, | ||
AAPL$AAPL.Adjusted, | ||
AMZN$AMZN.Adjusted, | ||
FB$FB.Adjusted, | ||
META$META.Adjusted, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
cc @jingningzhang1
Fix broken links
There were some examples that render nothing and others that now prevent the docs from building (docs haven't built in three years), so removed them here. There are probably ways to adjust the examples, use different packages etc, but that would be a much bigger job.