Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix links #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 28, 2024
Merged

Fix links #107

merged 26 commits into from
May 28, 2024

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented May 27, 2024

cc @jingningzhang1

Fix broken links

There were some examples that render nothing and others that now prevent the docs from building (docs haven't built in three years), so removed them here. There are probably ways to adjust the examples, use different packages etc, but that would be a much bigger job.

@LiamConnors LiamConnors requested a review from red-patience May 27, 2024 17:24
@LiamConnors LiamConnors marked this pull request as draft May 27, 2024 20:42
@LiamConnors LiamConnors marked this pull request as ready for review May 28, 2024 18:49
@LiamConnors LiamConnors requested a review from gvwilson May 28, 2024 18:49
@@ -86,44 +86,3 @@ fig <- plot_ly(

fig
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the big deletion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it uses maptools, which looks like it is no longer available.

https://cran.r-project.org/web/packages/maptools/index.html

I don't have enough knowledge of r to rewrite with these recommended packages.

@@ -22,7 +22,7 @@ knitr::opts_chunk$set(message = FALSE, warning=FALSE)
The bar shows the target value, and the shading represents the progress toward that goal. Gauge charts, known as
speedometer charts as well. This chart type is usually used to illustrate key business indicators.

The example below displays a basic gauge chart with default attributes. For more information about different added attributes check [indicator](https://plotly.com/r/indicator/) tutorial.
The example below displays a basic gauge chart with default attributes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this removed.

for (i in tickers){
getSymbols(i,
from = "2018-01-01",
to = "2019-12-31")}
stock <- data.frame(GOOG$GOOG.Adjusted,
AAPL$AAPL.Adjusted,
AMZN$AMZN.Adjusted,
FB$FB.Adjusted,
META$META.Adjusted,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@LiamConnors LiamConnors merged commit afcb7d5 into master May 28, 2024
1 check passed
@LiamConnors LiamConnors deleted the fix-links branch May 28, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants