Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(layout): add LayoutPolar #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2025
Merged

feat(layout): add LayoutPolar #355

merged 2 commits into from
Sep 6, 2025

Conversation

dustypomerleau
Copy link
Contributor

@dustypomerleau dustypomerleau commented Aug 27, 2025 •
edited
Loading

Happy for any feedback/advice while I work on this. Eventually closes #352.

@dustypomerleau dustypomerleau marked this pull request as draft August 27, 2025 06:56
@dustypomerleau dustypomerleau changed the title Draft: LayoutPolar Draft: implement LayoutPolar Aug 27, 2025
@andrei-ng
Copy link
Collaborator

Looks good so far.
If you could add an example in examples/, then I can expand the mdBook such that it is also included in the book.

andrei-ng
andrei-ng reviewed Aug 29, 2025
View reviewed changes
@dustypomerleau dustypomerleau force-pushed the layoutpolar branch 5 times, most recently from 3d76518 to 471e9f0 Compare August 31, 2025 08:19
andrei-ng
andrei-ng reviewed Aug 31, 2025
View reviewed changes
@dustypomerleau dustypomerleau force-pushed the layoutpolar branch 2 times, most recently from 0940572 to bb46ac6 Compare September 5, 2025 13:21
@dustypomerleau dustypomerleau changed the title Draft: implement LayoutPolar feat(layout): add LayoutPolar Sep 5, 2025
@dustypomerleau dustypomerleau marked this pull request as ready for review September 5, 2025 13:26
@dustypomerleau dustypomerleau force-pushed the layoutpolar branch 2 times, most recently from f5a7957 to 49e9132 Compare September 5, 2025 23:21
@dustypomerleau
Copy link
Contributor Author

Ok, I finally have green tests using --features=chromedriver,webdriver_download, so I think I'm happy for a review when you have time.

I noticed while adding a layout to the ScatterPolar example that it's the only one without an ANCHOR comment tag—not sure if that's intentional or not.

@andrei-ng
Copy link
Collaborator

Ok, I finally have green tests using --features=chromedriver,webdriver_download, so I think I'm happy for a review when you have time.

I noticed while adding a layout to the ScatterPolar example that it's the only one without an ANCHOR comment tag—not sure if that's intentional or not.

I will review it this weekend. I will check the Anchor. It is needed for inclusion in the book. I need to see if it is an omission or international.

Thank you very much for the PR!

@andrei-ng
Copy link
Collaborator

Looks good. Merging it. I will make a new release soon.

@andrei-ng andrei-ng merged commit e4f02e1 into plotly:main Sep 6, 2025
31 of 32 checks passed
@dustypomerleau dustypomerleau deleted the layoutpolar branch September 7, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-ng andrei-ng andrei-ng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing the range of the angular axis in ScatterPolar
2 participants
@dustypomerleau @andrei-ng