Animations - Only in Offline mode #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-for-matlab into animations
|
Works fine for me! |
gilbertogalvis
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Excellent work! My only suggestion (coming from @jackparmer) is the request to use camelCase for code development.
|
Added options to specify FrameDuration and FrameTransitionDuration to control the speed of the animations. |
There was a problem hiding this comment.
When run updated code, it turns out following error
Reviewing the code I found an error between lines #267 and #268 in plotlyfig.m file (please fix it. It is a missing end command).
Anyway when I fix previous error and run the following code
[xmat,ymat,zmat] = peaks(100);
xvec = xmat(:);
yvec = ymat(:);
zvec = zmat(:);
comet3(xvec,yvec,zvec)
fig2plotly(gcf, 'offline', true, 'TreatAs', 'comet3');
This takes a long time to run and in at end throws a memory overflow error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for animated lines and comets.
Sample code to try:
Note: This is supported in offline mode.