Make <rule> element optional in ruleset_2_0_0.xsd#5266
Open
hassanalami wants to merge 1 commit intopmd:mainfrom
Open
Make <rule> element optional in ruleset_2_0_0.xsd#5266hassanalami wants to merge 1 commit intopmd:mainfrom
hassanalami wants to merge 1 commit intopmd:mainfrom
Conversation
Generated by 🚫 Danger |
adangel
requested changes
Oct 8, 2024
Member
adangel
left a comment
There was a problem hiding this comment.
See my comment here: #5265 (comment)
We should better do a cleanup then maintain empty/useless rulesets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
ruleset_2_0_0.xsdschema to make the<rule>element optional. The current schema requires at least one<rule>element, but several existing ruleset files do not have this element. This change setsminOccurs="0"for the<rule>element to avoid validation errors on these files.Related issues
<rule>element optional inruleset_2_0_0.xsd#5265Ready?
./mvnw clean verifypasses (checked automatically by github actions)