Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Get-PnPTenantTemplate: Fixing scope name generation#2874

Merged
erwinvanhunen merged 3 commits into
pnp:devfrom
heinrich-ulbricht:dev-fix-token-handling
Oct 5, 2020
Merged

Get-PnPTenantTemplate: Fixing scope name generation#2874
erwinvanhunen merged 3 commits into
pnp:devfrom
heinrich-ulbricht:dev-fix-token-handling

Conversation

@heinrich-ulbricht

Copy link
Copy Markdown
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

N/A

What is in this Pull Request ?

While using Get-PnPTenantTemplate to extract a team I noticed that the scope names are sometimes incorrect. The following things happened:

  • the resource already contained the leading https:// resulting in a scope name starting with https://https://
  • the resource ended with / causing the scope name to end with ///.default

Sample error:
image

@erwinvanhunen And I replaced the // with / so right before the .default is always only one /.

Hope this makes sense. For me this fixed my problems.

@erwinvanhunen

Copy link
Copy Markdown
Member

Thank you! While this should have been fixed on engine level already, an extra check doesn't hurt as such.

@erwinvanhunen erwinvanhunen merged commit a22e84a into pnp:dev Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants