feat: set default import method in Win to hardlink #7564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
requested changes
Jan 24, 2024
fs/indexed-pkg-importer/src/index.ts
Outdated
Comment on lines
30
to
35
| // Set default import method to hardlinking on Windows | ||
| if (process.platform === 'win32') { | ||
| packageImportMethodLogger.debug({ method: 'hardlink' }) | ||
| return hardlinkPkg.bind(null, linkOrCopy) | ||
| } | ||
|
|
There was a problem hiding this comment.
It might be not always possible to create a hard link. For instance, if the store is not on the same drive as the node_modules. It should still fall back to copying in that case.
There was a problem hiding this comment.
Maybe I should revert the refactor and use 74f770e?
zkochan
approved these changes
Jan 24, 2024
zkochan
added a commit
that referenced
this pull request
Jan 24, 2024
Close #7524 Close #7547 Close #7492 --------- Co-authored-by: Zoltan Kochan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default
package-import-methodto hardlinks in Windows to avoid performance errors in systems without Dev Drives.Close #7524
Close #7547
Close #7492