feat: display packed files list in pnpm pack
#8707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
reviewed
Nov 4, 2024
zkochan
reviewed
Nov 4, 2024
zkochan
approved these changes
Nov 5, 2024
zkochan
pushed a commit
that referenced
this pull request
Nov 5, 2024
julienp
added a commit
to pulumi/pulumi
that referenced
this pull request
Nov 13, 2024
For pnpm versions <9.13, pnpm pack outputs a single line with the name of the tarball. On pnpm versions >=9.13, pnpm pack lists all the packed files, and the last line is the tarball. pnpm/pnpm#8707
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
Nov 13, 2024
For pnpm versions <9.13, pnpm pack outputs a single line with the name of the tarball. On pnpm versions >=9.13, pnpm pack lists all the packed files, and the last line is the tarball. pnpm/pnpm#8707
1 task
|
This ended up breaking CI for us, since we were relying on the stdout from ResolutionIn case anyone else is getting failures because they were relying on the import { execa } from 'execa';
// ...
// Pack and install Preflight globally
- const { stdout: pnpmPackTarballPath } = await execa`pnpm pack`;
+ const pnpmPackTarballPath = (await execa`pnpm pack`).stdout
+ .split('\n')
+ .find((line) => line.match(/^upleveled-preflight-.*\.tgz$/));
+
+ if (!pnpmPackTarballPath) {
+ throw new Error('Failed to find the tarball path in `pnpm pack` output');
+ } |
|
Sorry for that. It actually broke some of my integrations as well. We should add a JSON output option. |
|
@zkochan ok thanks, created an issue to track |
|
Refer PR: #8765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8676
It's useful to display packed files since
pnpm packonly shows tarball filename nowBefore
After