-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: pnpm.ignoredBuiltDependencies for muting warnings about ignored dependency builds #8958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pnpm.ignoredBuiltDependencies for muting warnings about ignored dependency builds #8958
Conversation
This is not so simple. The suggestion was to don't warn about dependencies included in the "never" list. |
Sorry, I misunderstood what he meant. I will try to modify the code logic according to your explanation. |
Now the problem with this change is that if someone will add the neverBuiltDependencies field while there is no onlyBuiltDependencies field, all the dependencies will be automatically allowed to be built. I'll make onlyBuiltDependencies an empty array even if neverBuiltDependencies is set. But with that change it becomes impossible to allow all dependencies to be built. Which some users might want to get the pre v10 behaviour. Maybe we could allow to disable the behaviour by setting onlyBuiltDependencies to |
Maybe it would be better to create a new field for excluding dependencies from the warning. Something like |
onlyBuiltDependencies
and neverBuiltDependencies
Can we make these configurations global? Configuring each project separately in a project with multiple packages can be troublesome. refer #8891 (comment) |
Responded #8891 (comment) |
close #8935