client: add extra_headers to stream_request() #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…poe into feature/default_headers
agamble-quora
requested changes
Jun 16, 2025
src/fastapi_poe/client.py
Outdated
| @property | ||
| def headers(self) -> dict[str, str]: | ||
| headers = {"Accept": "application/json"} | ||
| headers = {**self.default_headers, "Accept": "application/json"} |
There was a problem hiding this comment.
Is the order here intentional to not allow overriding the "Accept" header?
There was a problem hiding this comment.
Yes it was intentional, but this was added before adding extra_headers to stream_request(). Now I feel like it makes more sense to rename this field to extra_headers too, and allow overriding existing header values. Updated the logic here, PLMK if you have concerns with the new logic.
agamble-quora
approved these changes
Jun 17, 2025
agamble-quora
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added extra_headers as an optional param on stream_request() to allow passing custom headers
Changes Made
Testing Done
Version
Breaking Changes
Checklist