[COOK-2297] more gracefully handle pip packages from VCS and source archives #28
Conversation
[COOK-2297] more gracefully handle pip packages from VCS and source archives
| pip_cmd('install', version == 'latest' ? '' : "==#{version}") | ||
| # if a version isn't specified (latest), is a source archive (ex. http://my.package.repo/SomePackage-1.0.4.zip), | ||
| # or from a VCS (ex. git+https://git.repo/some_pkg.git) then do not append a version as this will break the source link | ||
| if version == 'latest' || @new_resource.name.downcase.start_with?('http:') || ['git', 'hg', 'svn'].include?(@new_resource.name.downcase.split('+')[0]) |
There was a problem hiding this comment.
Doesn't take HTTPS into account.
There was a problem hiding this comment.
You're correct, I failed to take that into account. Perhaps a single regex test would be better? I'm not sure of the proper way to update this, though. Update the associated ticket and this pull request or submit a new ticket and pull request?
|
Just as a general comment, this makes idempotence much harder to manage. |
|
While I agree that using these types of URLs makes idempotence impossible (since they can point to a specific version or 'latest'), the only other option is to not support them at all. Currently if |
This small change prevents the (rather specific) use case of specifying a
versionwith a package in version control from causing an error. Currently when aversionis specified it will be appended to the resource name, breaking any URLs.