This repository was archived by the owner on Oct 2, 2018. It is now read-only.
Use :install as the default action for python_pip #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,13 @@ | |||
| # | |||
|
|
|||
| actions :install, :upgrade, :remove, :purge | |||
| default_action :install | |||
|
|
|||
| # Covers 0.10.8 and earlier :default_action | |||
There was a problem hiding this comment.
If this is used on earlier versions, #default_action will throw MethodNotFound as it is currently written, so backwards compat is moot. Could add a defined? check on it maybe?
There was a problem hiding this comment.
I stole this code from here: http://wiki.opscode.com/pages/viewpage.action?pageId=7274964#LightweightResourcesandProviders(LWRP)-DefaultAction. Is that not accurate then?
There was a problem hiding this comment.
I think the intent is lost there a bit, you can use one or the other, but both doesn't make sense :) Now paging @jtimberman for verification I'm not making things up again.
jtimberman
pushed a commit
that referenced
this pull request
Feb 13, 2013
…default_action Use :install as the default action for python_pip
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://tickets.opscode.com/browse/COOK-2376