This repository was archived by the owner on Oct 2, 2018. It is now read-only.
COOK-2468 - Chef 11 compat fixes #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the `Chef::Exceptions::ImmutableAttributeModification` which is thrown when run on Chef 11+
This also fixes [FC017] in addition to providing better encapsulation.
Checking for a non-zero exit code accomplishes the same thing as rescuing *::ShellCommandFailed.
The 1.0 branch of test-kitchen is based on Fletcher Nichol's excellent Jamie CI codebase.
| @@ -25,7 +25,7 @@ | |||
| if platform_family?('rhel') && major_version < 6 | |||
| include_recipe 'yum::epel' | |||
| python_pkgs = ["python26", "python26-devel"] | |||
| node['python']['binary'] = "/usr/bin/python26" | |||
| node.set['python']['binary'] = "/usr/bin/python26" | |||
There was a problem hiding this comment.
Curious if the normal attribute precedence is a Chef 10 attribute precedence fail-ism. Do you know?
There was a problem hiding this comment.
@btm I thought normal and set were just aliases: https://github.com/opscode/chef/blob/10-stable/chef/lib/chef/node.rb#L263-L272
jtimberman
pushed a commit
that referenced
this pull request
Feb 28, 2013
COOK-2468 - Chef 11 compat fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-kitchen1.0.0 alpha support