Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 2, 2018. It is now read-only.

Sets version only when installing from source. #49

Closed
wants to merge 1 commit into from
Closed

Sets version only when installing from source. #49

wants to merge 1 commit into from

Conversation

patcon
Copy link

@patcon patcon commented Jul 16, 2013

@coderanger
Copy link
Member

I think you got this logic backwards, it only sets it for non-source.

@patcon patcon mentioned this pull request Jul 16, 2013
Open
@patcon
Copy link
Author

patcon commented Jul 16, 2013

Ah. Oops. Missed your comment earlier, but hit it myself while using my PR in a Cheffile :)
Force-pushed the fix.

@sethvargo
Copy link
Contributor

@patcon please see the comments on the JIRA ticket

coderanger added a commit that referenced this pull request Jan 28, 2014
@coderanger
Trying a better fix for #49.
d5abbaa
@coderanger
Copy link
Member

@patcon What do you think of d5abbaa? Trying to make something that reacts well in the face of wrapper cookbooks and such.

@patcon
Copy link
Author

patcon commented Jan 28, 2014

Hm. I've lost a lot of context, but I think my issue was addressed in opscode ticket. Sorry I can't be more helpful :)

@patcon patcon closed this Jan 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patcon @coderanger @sethvargo