This repository was archived by the owner on Oct 2, 2018. It is now read-only.
Catch exception when pip not already installed #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pip is not already installed, `current_installed_version` throws an uncaught `Mixlib::ShellOut::ShellCommandFailed`. It tries to catch a `Chef::Exceptions::ShellCommandFailed`, but that doesn't work. This patch makes it unconditionally return `nil` if an exception occurs, so that pip can be installed properly. There's probably a better way to fix this, but alas, I am not well-versed in Ruby.
|
Eugh, that |
…ust use a `rescue`.
|
The rescue for 0.10.8 was resolved via COOK-1282, and is released in python cookbook v1.0.8. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pip is not already installed,
current_installed_versionthrows an uncaught
Mixlib::ShellOut::ShellCommandFailed. It triesto catch a
Chef::Exceptions::ShellCommandFailed, but that doesn'twork. This patch makes it unconditionally return
nilif an exceptionoccurs, so that pip can be installed properly.
There's probably a better way to fix this, but alas, I am not
well-versed in Ruby.