Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

s11s11
Copy link

@s11s11 s11s11 commented Sep 19, 2025

This patch fixes suspend issues on RX 5000 GPUs.

brettsheffield and others added 8 commits September 8, 2025 17:58
Fix the regression introduced in 9e30ecf whereby IPv4 broadcast
packets were having their ethernet destination field mangled.  This
broke WOL magic packets and likely other IPv4 broadcast.

The regression can be observed by sending an IPv4 WOL packet using
the wakeonlan program to any ethernet address:

 wakeonlan 46:3b:ad:61:e0:5d

and capturing the packet with tcpdump:

 tcpdump -i eth0 -w /tmp/bad.cap dst port 9

The ethernet destination MUST be ff:ff:ff:ff:ff:ff for broadcast, but is
mangled with 9e30ecf applied.

Revert the change made in 9e30ecf and ensure the MTU value for
broadcast routes is retained by calling ip_dst_init_metrics() directly,
avoiding the need to enter the main code block in rt_set_nexthop().

Simplify the code path taken for broadcast packets back to the original
before the regression, adding only the call to ip_dst_init_metrics().

The broadcast_pmtu.sh selftest provided with the original patch still
passes with this patch applied.

Fixes: 9e30ecf ("net: ipv4: fix incorrect MTU in broadcast routes")
Signed-off-by: Brett A C Sheffield <[email protected]>
Signed-off-by: Michael Aaron Murphy <[email protected]>
Commit 9e30ecf ("net: ipv4: fix incorrect MTU in broadcast routes")
introduced a regression where local-broadcast packets would have their
gateway set in __mkroute_output, which was caused by fi = NULL being
removed.

Fix this by resetting the fib_info for local-broadcast packets. This
preserves the intended changes for directed-broadcast packets.

Cc: [email protected]
Fixes: 9e30ecf ("net: ipv4: fix incorrect MTU in broadcast routes")
Reported-by: Brett A C Sheffield <[email protected]>
Closes: https://lore.kernel.org/regressions/[email protected]
Signed-off-by: Oscar Maes <[email protected]>
Reviewed-by: David Ahern <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Removes all display modes with more than 240 Hz for the integrated display
on a TUXEDO Stellaris 16 Gen7, because using the iGPU with higer refresh
rates causes screen flicker.

Signed-off-by: Tim Guttzeit <[email protected]>
Co-developed-by: Werner Sembach <[email protected]>
Signed-off-by: Werner Sembach <[email protected]>
Link: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14616
Signed-off-by: Tim Crawford <[email protected]>
This patch fixes suspend issues on RX 5000 GPUs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants