Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump server versions#643

Closed
illusional wants to merge 7 commits into
devfrom
bump-server-versions
Closed

Bump server versions#643
illusional wants to merge 7 commits into
devfrom
bump-server-versions

Conversation

@illusional

Copy link
Copy Markdown
Contributor

@illusional illusional requested a review from milo-hyben January 9, 2024 05:42

@milo-hyben milo-hyben left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, but pip is not happy :-)

@illusional

Copy link
Copy Markdown
Contributor Author

Upgrading fastapi (past this commit) meant our openapi version was pushed to 3.1, which was a pain because:

  • We use an intentionally outdated openapi-generator (as newer ones didn't work), which doesn't support 3.1
  • Swagger-ui-react should technically support 3.1, but bumping this up to a version that does causes pain and conflicts with React and React Router.

So we should park this for now, and try again later. Though, to upgrade this, we may need to ditch our current API generator, or hack it to make it work with 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants