Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change reactive.Effect to output and render.text #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

Change reactive.Effect to output and render.text #103

merged 1 commit into from
Jul 11, 2023

Conversation

pckroon
Copy link
Contributor

@pckroon pckroon commented Jul 11, 2023

As promised.
Fixes #102

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nealrichardson
nealrichardson approved these changes Jul 11, 2023
View reviewed changes
Copy link

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(To verify, look at the shinylive example linked on the issue. This change updates the example to match.)

@nealrichardson
Copy link

CI failure is #104, so I'll merge.

@nealrichardson nealrichardson merged commit f208a34 into posit-dev:main Jul 11, 2023
@pckroon pckroon deleted the fix_102 branch July 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@reactive.Effect not rendered
3 participants
@pckroon @CLAassistant @nealrichardson