Fix childless at-rule losing its semicolon before a comment - #2115
Merged
Conversation
A childless (statement) at-rule that is the last non-comment child but is followed by comment siblings was stringified without its terminating semicolon. On re-parse the trailing comments were folded into the at-rule prelude and dropped, so building such a tree with append() or insertBefore() silently lost the comment nodes. Emit the semicolon when a childless at-rule still has following siblings so the output round-trips.
Member
|
Thanks. Released in 8.5.21. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building a tree I put a childless at-rule (for example
@import) just before a comment node usingappend()/insertBefore(), and the comment vanished after a stringify + re-parse round-trip.The stringifier treats the last non-comment child as the one whose semicolon is optional, ignoring any trailing comments. That is fine for a declaration, but a childless at-rule reads everything up to the next
;/{as its prelude, so without the semicolon the following comments get folded into the at-rule and are dropped on re-parse.The fix emits the semicolon when a childless at-rule still has following siblings, so the output round-trips. A genuinely last at-rule with nothing after it is unchanged.
Tested with two new unit tests (root and nested cases) and the full
pnpm testsuite.