This repository was archived by the owner on Feb 18, 2022. It is now read-only.
Preserve spaces in multi-part values. #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug with space separated values. Previously, `0 10px 20px 30px` would be exported with commas: `0,10px,20px,30px`. This commit preverses spaces, to export `0 10px 20px 30px` as expected.
jonathantneal
approved these changes
Jan 3, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug with space separated values. Previously,
0 10px 20px 30pxwould be exported with commas:0,10px,20px,30px. This commit preverses spaces, to export0 10px 20px 30pxas expected.Hi! We use
postcss-custom-propertiesa bunch here at @UrbanCompass ! Thank you for all your work on PostCSS!I recently came across a bug using
exportTo. Multi-part values like0 10px 20px 30pxwould be exported with commas instead of spaces:0,10px,20px,30px. Exported values would look even more wild if there were commas already. For example,This PR resolves that. Tests updated as well 😸