pg_dump: Error message improvements

alvherre · alvherre · commit 58dc80acc5eb · 2023-05-17T19:13:08.000+02:00
Remove spurious semicolon from one error message, and print the
offending value of a parameter reported as invalid in another.
diff --git a/src/bin/pg_dump/compress_zstd.c b/src/bin/pg_dump/compress_zstd.c
@@ -63,7 +63,7 @@ _Zstd_CCtx_setParam_or_die(ZSTD_CStream *cstream,
 
 	res = ZSTD_CCtx_setParameter(cstream, param, value);
 	if (ZSTD_isError(res))
-		pg_fatal("could not set compression parameter: \"%s\": %s",
+		pg_fatal("could not set compression parameter \"%s\": %s",
 				 paramname, ZSTD_getErrorName(res));
 }
 
@@ -498,7 +498,7 @@ Zstd_open(const char *path, int fd, const char *mode,
 			pg_fatal("could not initialize compression library");
 	}
 	else
-		pg_fatal("unhandled mode");
+		pg_fatal("unhandled mode \"%s\"", mode);
 
 	return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ _Zstd_CCtx_setParam_or_die(ZSTD_CStream *cstream,`
`63`	`63`
`64`	`64`	`res = ZSTD_CCtx_setParameter(cstream, param, value);`
`65`	`65`	`if (ZSTD_isError(res))`
`66`		`- pg_fatal("could not set compression parameter: \"%s\": %s",`
	`66`	`+ pg_fatal("could not set compression parameter \"%s\": %s",`
`67`	`67`	`paramname, ZSTD_getErrorName(res));`
`68`	`68`	`}`
`69`	`69`
`@@ -498,7 +498,7 @@ Zstd_open(const char path, int fd, const char mode,`
`498`	`498`	`pg_fatal("could not initialize compression library");`
`499`	`499`	`}`
`500`	`500`	`else`
`501`		`- pg_fatal("unhandled mode");`
	`501`	`+ pg_fatal("unhandled mode \"%s\"", mode);`
`502`	`502`
`503`	`503`	`return true;`
`504`	`504`	`}`